[SYCL][Driver] Revert -cl-fast-relaxed-math propagation #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntel#2680)" This reverts commit ce08889. Reason: the issue with this implementation is that we can't preserve correct correlation between the option and the source impacted by this option. `-ffast-math` is applied to C++ translation unit, whereas single SPIR-V module might include code sections from multiple translation units and some of them might be compiled with `-fno-fast-math`.
mdtoguchi
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ce08889.
Reason: the issue with this implementation is that we can't preserve
correct correlation between the option and the source impacted by this
option.
-ffast-mathis applied to C++ translation unit, whereas singleSPIR-V module might include code sections from multiple translation
units and some of them might be compiled with
-fno-fast-math.