[Driver][NFC] Improve testing of -fsycl-device-only #2708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few key checks for -fsycl-device-only which were previously missing when comparing to -fsycl device compilations.
AGindinson
reviewed
Oct 30, 2020
AGindinson
approved these changes
Oct 30, 2020
jsji
pushed a commit
that referenced
this pull request
Sep 21, 2024
We already ignore llvm.trap, adding llvm.debugtrap as well. Signed-off-by: Marcos Maronas <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@3e523388f13bcc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few key checks for -fsycl-device-only which were previously
missing when comparing to -fsycl device compilations.