[SYCL][CUDA] Support GroupBroadcast with 32-bit id #2759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of the broadcast algorithm with the sub_group class clamps the sub-group local id into a uint32_t. libspirv was missing an entry point for this case. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
bug
|
Sorry for the link-unlink. I wanted to reference #2754 because this is a partial fix. I'll be addressing the load_store test with a separate PR. |
bader
approved these changes
Nov 11, 2020
alexbatashev
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the broadcast algorithm with the sub_group class clamps the
sub-group local id into a uint32_t. libspirv was missing an entry
point for this case.
Signed-off-by: John Pennycook [email protected]