Skip to content

[SYCL] Add code examples for all SYCL FPGA loop attributes #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 16, 2020

Conversation

smanna12
Copy link
Contributor

@smanna12 smanna12 commented Nov 12, 2020

This is a follow-up in #2715 (comment)

This patch improves the documentation by adding code examples for all FPGA loop
attributes that we did not have before.

Signed-off-by: Soumi Manna [email protected]

This is a followup in intel#2715 (comment). This patch improves the
documentation by adding code examples for all FPGA loop attributes that
we did not have before.

Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
@smanna12 smanna12 linked an issue Nov 12, 2020 that may be closed by this pull request
@smanna12 smanna12 marked this pull request as ready for review November 12, 2020 05:53
@Fznamznon Fznamznon requested a review from MrSidims November 12, 2020 10:54
MrSidims
MrSidims previously approved these changes Nov 12, 2020
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it would be valuable to also add an example like this:

template<int N>
void bar() {
  [[intel::loop_attr(N)]] for(;;) { }
}

Signed-off-by: Soumi Manna <[email protected]>
@smanna12
Copy link
Contributor Author

smanna12 commented Nov 12, 2020

May be it would be valuable to also add an example like this:

template<int N>
void bar() {
  [[intel::loop_attr(N)]] for(;;) { }
}

@MrSidims Thanks for looking into this. Yes, i agree with you that it would be valuable to add template examples. I have updated doc with the template exmaples.

Signed-off-by: Soumi Manna <[email protected]>
@smanna12 smanna12 requested a review from MrSidims November 16, 2020 06:57
@bader bader merged commit 6b95820 into intel:sycl Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code examples for all SYCL loop attributes
4 participants