[SYCL] Store stream offset in flush buffer's memory #2767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlychkov
requested review from
alexbatashev,
romanovvlad,
againull and
s-kanaev
romanovvlad
reviewed
Nov 13, 2020
s-kanaev
reviewed
Nov 13, 2020
sycl/test/on-device/basic_tests/stream/stream_copies_buffer_sync.cpp
Outdated
Show resolved
Hide resolved
romanovvlad
reviewed
Nov 18, 2020
romanovvlad
reviewed
Nov 18, 2020
romanovvlad
reviewed
Nov 18, 2020
s-kanaev
reviewed
Nov 18, 2020
mlychkov
commented
Nov 19, 2020
s-kanaev
reviewed
Nov 19, 2020
sycl/test/on-device/basic_tests/stream/stream_flush_buf_init_dep.cpp
Outdated
Show resolved
Hide resolved
Flush buffer's offset is not shared between copies of stream object. It may lead to a loss or double printing of work items' statements written in one of copied stream objects. Use two first bytes of work item's flush buffer for storing buffer's offset to share it between copies of stream object. Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
mlychkov
force-pushed
the
private/mlychkov/share_stream_offset_between_copies
branch
from
cf5d6b1 to
5d948a2
Compare
s-kanaev
reviewed
Nov 30, 2020
Signed-off-by: Mikhail Lychkov <[email protected]>
s-kanaev
approved these changes
Dec 1, 2020
|
/summary:run |
|
@againull , friendly ping. |
againull
approved these changes
Dec 2, 2020
mlychkov
deleted the
private/mlychkov/share_stream_offset_between_copies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush buffer's offset is not shared between copies of stream object.
It may lead to a loss or double printing of work items' statements
written in one of copied stream objects.
Use two first bytes of work item's flush buffer for storing buffer's
offset to share it between copies of stream object.
Signed-off-by: Mikhail Lychkov [email protected]