Skip to content

[SYCL] minor fixes found from klocwork review #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2020
Merged

[SYCL] minor fixes found from klocwork review #2780

merged 3 commits into from
Dec 1, 2020

Conversation

cperkinsintel
Copy link
Contributor

No description provided.

keryell
keryell suggested changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But at the end since all ends up into Log, perhaps you can just accumulate the information directly into Log instead of using intermediate std::string.
Anyway, not a critical path in the implementation... :-)

@cperkinsintel
changes requested by review
7479c33 
Signed-off-by: Chris Perkins <[email protected]>
@cperkinsintel cperkinsintel marked this pull request as ready for review November 17, 2020 19:51
@cperkinsintel
Copy link
Contributor Author

ping to reviewers/code-owners.

@cperkinsintel
Copy link
Contributor Author

@kbobrovs - you are the code owner, correct? Could you review and approve this PR? It can't move forward without you.

keryell
keryell reviewed Nov 20, 2020
View reviewed changes
@cperkinsintel
Copy link
Contributor Author

@kbobrovs - ping

@cperkinsintel
Copy link
Contributor Author

@kbobrovs - ping again -

kbobrovs
kbobrovs approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 07d0812 into intel:sycl Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell requested changes

@kbobrovs kbobrovs kbobrovs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cperkinsintel @keryell @kbobrovs @bader