Skip to content

[SYCL][ESIMD] Update vc-intrinsics #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SYCL][ESIMD] Update vc-intrinsics #2781

wants to merge 1 commit into from

Conversation

asi-sc
Copy link
Contributor

@asi-sc asi-sc commented Nov 17, 2020

This update will allow to remove the temporary workaround brought by #2015 pull request.

@asi-sc asi-sc requested a review from bader as a code owner November 17, 2020 08:39
bader
bader approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tests cover this change?

@asi-sc
Copy link
Contributor Author

asi-sc commented Nov 17, 2020

What tests cover this change?

Each ESIMD test covers this change, e.g. llvm/test/SYCLLowerIR/esimd_lower_intrins.ll

@bader
Copy link
Contributor

bader commented Nov 17, 2020

What tests cover this change?

Each ESIMD test covers this change, e.g. llvm/test/SYCLLowerIR/esimd_lower_intrins.ll

Are all ESIMD tests fail w/o this patch?
I meant: is there any observable change from this patch, which is reflected in the tests?

The description mentioned:

This update will allow to remove the temporary workaround brought by #2015 pull request.

Why don't we remove the workaround in this PR to confirm this statement?

@asi-sc
Copy link
Contributor Author

asi-sc commented Nov 17, 2020

Well.. I've mistaken a bit. The vc-intrinsics change that I wanted to propagate here is only in SPIRV reader adapter, so, it is not necessary to bring it in dpc++. The patch removal will be possible when IGC is updated with the required vc-intrinsics version.

@asi-sc asi-sc closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asi-sc @bader