[SYCL] Rename FPGA kernel attribute stall_enable #2787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FPGA kernel attribute [[intel::stall_enable]] should be renamed to [[intel::use_stall_enable_clusters]] for SYCL to be consistent with the name used in OpenCL and HLS. There is no need to formally deprecate the old name, because users have not had a chance to use the old name yet. Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
approved these changes
Nov 18, 2020
MrSidims
approved these changes
Nov 18, 2020
|
Thank you everyone for the review. @bader, Patch is ready for merge. |
I know. It's not merged yet, because we usually give 24 hours for review feedback from developers not explicitly assigned as reviewers. |
Thanks for the information. I was not aware of it. |
elizabethandrews
approved these changes
Nov 18, 2020
premanandrao
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FPGA kernel attribute [[intel::stall_enable]] should be
renamed to [[intel::use_stall_enable_clusters]] for SYCL to
be consistent with the name used in OpenCL and HLS.
There is no need to formally deprecate the old name, because
users have not had a chance to use the old name yet.
Signed-off-by: Soumi Manna [email protected]