Skip to content

[SYCL][Driver] Do not customize optimizations for non-SPIR targets #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

bader
Copy link
Contributor

@bader bader commented Nov 19, 2020

All targets other than SPIR should be able to use standard optimization
pipeline.

All targets other than SPIR should be able to use standard optimization
pipeline.
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good, could you add a negative test?

@bader bader requested a review from mdtoguchi November 20, 2020 17:47
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bader bader merged commit cb069fe into intel:sycl Nov 21, 2020
@bader bader deleted the enable-optimizations branch November 21, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants