[NFC][SYCL] Update tests which were not properly working for Windows #2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few of the Driver sycl* tests were not configured properly to work in a windows environment and were disabled. Make the needed adjustments to the tests and break out any specific testing that needs Linux and Windows specificity.
|
This work is to address #888 |
AGindinson
reviewed
Nov 23, 2020
AGindinson
approved these changes
Dec 3, 2020
jsji
pushed a commit
that referenced
this pull request
Dec 31, 2024
Add a new form of load/store operations for cooperative matrices that accepts two separate arguments: the row index and the column index. Unlike the original approach requiring a pointer to the matrix base, this new form of load/store operations is expected to yield better optimized code on 2dblock read/write instructions on PVC. CapabilityCooperativeMatrixOffsetInstructionsINTEL = 6238 OpCooperativeMatrixLoadOffsetINTEL = 6239 OpCooperativeMatrixStoreOffsetINTEL = 6240 Spec: #12497 Original commit: KhronosGroup/SPIRV-LLVM-Translator@193661c352de3ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the Driver sycl* tests were not configured properly to work
in a windows environment and were disabled. Make the needed adjustments
to the tests and break out any specific testing that needs Linux and
Windows specificity.