Skip to content

[SYCL] Fix instantiation after specialization warning #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

[SYCL] Fix instantiation after specialization warning #2818

merged 1 commit into from
Dec 1, 2020

Conversation

alexbatashev
Copy link
Contributor

Explicit instantiation of template that occurs after an explicit specialization
has no effect. Move template specializations to header to avoid this kind
of warnings.

[SYCL] Fix instantiation after specialization warning
5b6054d 
Explicit instantiation of template that occurs after an explicit specialization
has no effect. Move template specializations to header to avoid this kind
of warnings.
@alexbatashev alexbatashev requested a review from a team as a code owner November 25, 2020 08:06
smaslov-intel
smaslov-intel approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to add a test?

@alexbatashev
Copy link
Contributor Author

Don't you want to add a test?

Tests won't help here. I intend to enable this warning for SYCL target (it seems to be supported by our GCC versions), but that's the job for a different PR.

@romanovvlad romanovvlad merged commit 56b9a1d into intel:sycl Dec 1, 2020
@alexbatashev alexbatashev deleted the kernel_impl_inst_after_spec branch December 1, 2020 14:27
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Dec 2, 2020
[SYCL] Enable instantiation after specialization warning where possible
f8b3f2a 
This is a followup for intel#2818
@alexbatashev alexbatashev mentioned this pull request Dec 2, 2020
Merged
jsji pushed a commit that referenced this pull request Nov 7, 2024
@vmaksimo @jsji
Fix llvm.frexp intrinsic translation with SPV_KHR_untyped_pointers (#…
7be620b 
…2818)

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@e3b9ba378349313
@KseniyaTikhomirova KseniyaTikhomirova mentioned this pull request May 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbatashev @smaslov-intel @romanovvlad