Skip to content

[BuildBot] Uplift GPU RT version for Linux CI Process #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Nov 28, 2020

Uplift GPU RT version for Linux to 20.47.18513

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.
We should either wait for a driver update fixing the regression or apply a workaround I suggested here: #2807 (comment)

@dm-vodopyanov
Copy link
Contributor

Please check if PR #2851 fixes the uplifting after being merged.

@bader
Copy link
Contributor

bader commented Dec 2, 2020

Please check if PR #2851 fixes the uplifting after being merged.

Please, add your patch to this PR, CI system can validate the fix.

This patch updates Level Zero loader to 1.0.16 to support latest
versions of Level Zero runtime.
@bader
Copy link
Contributor

bader commented Dec 2, 2020

It works. @dm-vodopyanov, I suggest closing #2851 and commit both patches from this PR if #2851 pre-commit pass. What do you think?

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Dec 2, 2020

@bader sounds good to me, closed #2851
Upd. Sorry, forgot to wait for Jenkins/Summary status. Can it be run for this PR?

@bader
Copy link
Contributor

bader commented Dec 2, 2020

Can it be run for this PR?

You can still use #2851 results for loader version update validation.
But it must be done for this PR for a different reason - we run these tests any driver update.

@bader
Copy link
Contributor

bader commented Dec 2, 2020

/summary:run

@yanfeng3721
Copy link
Contributor

yanfeng3721 commented Dec 3, 2020

Regression detected by post commit CTS test, the mismatch information is as below:
[2020-12-03T04:56:53.545Z] 48: --- math_builtin_float_double
[2020-12-03T04:56:59.299Z] 48: . value: 0.8986363237370140755189140691072680056095123291015625 [3fecc1a0f6ae5732], reference: 0.89863632373701440858582145665423013269901275634765625 [3fecc1a0f6ae5735]
[2020-12-03T04:56:59.299Z] 48: . line: 152
[2020-12-03T04:56:59.299Z] 48: . tests case: 4600071. Correctness check failed.
[2020-12-03T04:57:38.741Z] 48: - fail

@yanfeng3721
Copy link
Contributor

Hi @bader , the same test can pass with 20.46.18421, so could it possible to reopen #2807 for uplift?

Regression detected by post commit CTS test, the mismatch information is as below:
[2020-12-03T04:56:53.545Z] 48: --- math_builtin_float_double
[2020-12-03T04:56:59.299Z] 48: . value: 0.8986363237370140755189140691072680056095123291015625 [3fecc1a0f6ae5732], reference: 0.89863632373701440858582145665423013269901275634765625 [3fecc1a0f6ae5735]
[2020-12-03T04:56:59.299Z] 48: . line: 152
[2020-12-03T04:56:59.299Z] 48: . tests case: 4600071. Correctness check failed.
[2020-12-03T04:57:38.741Z] 48: - fail

@bader
Copy link
Contributor

bader commented Dec 3, 2020

@yanfeng3721, it's quite possible a CTS bug, not DPC++.
I'm okay to merge #2807, while this issue is being investigated.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix SYCL-CTS failures.

@bader bader closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants