Skip to content

[SYCL] Fix isordered built-in function realisation #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 8, 2020
Merged

[SYCL] Fix isordered built-in function realisation #2841

merged 10 commits into from
Dec 8, 2020

Conversation

maximdimakov
Copy link
Contributor

No description provided.

@maximdimakov maximdimakov requested a review from a team as a code owner December 1, 2020 12:43
@maximdimakov maximdimakov requested a review from againull December 1, 2020 12:43
s-kanaev
s-kanaev reviewed Dec 2, 2020
View reviewed changes
@maximdimakov
[SYCL]Regression test for fix __s_long_mad_sat built-in function impl…
d50e250 
…ementation

Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Regression test for fix __s_long_mad_sat built-in function impl…
adb882b 
…ementation

Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Fixes in regression test
82732e5 
Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Clang-format fix in regression test
a16588b 
Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Clang-format fix regression test
d0596bd 
Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Fix isordered built-in function realization
df07886 
Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Regression test for isordered function was added
13789eb 
Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Clang-format fix regression test
91ccfc7 
Signed-off-by: mdimakov <[email protected]>
@maximdimakov
[SYCL]Format fix in regression test
8d44dfd 
Signed-off-by: mdimakov <[email protected]>
@bader bader changed the title Fix isordered built-in function realisation [SYCL] Fix isordered built-in function realisation Dec 4, 2020
@bader bader requested a review from s-kanaev December 4, 2020 16:49
@s-kanaev
Copy link
Contributor

s-kanaev commented Dec 4, 2020

/summary:run

s-kanaev
s-kanaev previously approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good.
Though, I believe, it should be augmented with checks for half and double types.

@bader bader merged commit 7867089 into intel:sycl Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@againull againull againull approved these changes

@s-kanaev s-kanaev s-kanaev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximdimakov @s-kanaev @againull @bader