Added tests to verify that devicelib APIs have no 'noinline' attribute. #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device compilers may (and should) honor 'noinline' attribute even when optimizations are turned on. At the same time, we do not want to prevent inlining of devicelib wrappers and fallback implementations, since this may result in degraded performance. These tests verify that the devicelib APIs are not marked with 'noinline' attribute. Signed-off-by: Vyacheslav Zakharin <[email protected]>
bader
approved these changes
Dec 2, 2020
|
Thank you for the review, @bader. The composite-spec-const fails have nothing to do with this change-set. How do I proceed with the merge? |
|
Don't we need to get an approval from @jinge90? |
Yes. I can merge if Ge approves. |
jinge90
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device compilers may (and should) honor 'noinline' attribute
even when optimizations are turned on. At the same time, we do not want
to prevent inlining of devicelib wrappers and fallback implementations,
since this may result in degraded performance. These tests verify that
the devicelib APIs are not marked with 'noinline' attribute.
Signed-off-by: Vyacheslav Zakharin [email protected]