[Driver][SYCL] Remove partial-link path when dealing with fat static … #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…archives For Linux, we would use partial linking to generate the object that contained the device binaries from a fat static archive. We are moving away from using partial linking to provide a better overall solution that is the same in regards to link behaviors for both Linux and Windows. The change here will allow for the extraction of device binaries from archives occur in the same manner as it does for Windows. We do full extraction from the archives, and do a full llvm-link with those extracted device binaries.
mdtoguchi
force-pushed
the
remove-partial-link-static-lib-linux
branch
from
46414eb to
190e839
Compare
|
Delay in fixing the conflict due to proxy issues which has finally been resolved. |
AGindinson
approved these changes
Dec 8, 2020
| @@ -5096,84 +5082,9 @@ void Driver::BuildActions(Compilation &C, DerivedArgList &Args, | |||
| OffloadBuilder.appendTopLevelLinkAction(Actions); | |||
|
|
|||
| // Go through all of the args, and create a Linker specific argument list. | |||
| // When dealing with fat static archives, this is fed into the partial link | |||
| // step on Linux or each archive is individually addressed on Windows. | |||
| // When dealing with fat static archives each archive is individually | |||
There was a problem hiding this comment.
Nit town:
Suggested change
| // When dealing with fat static archives each archive is individually | |
| // When dealing with fat static archives, each archive is individually |
sndmitriev
added a commit
to sndmitriev/llvm
that referenced
this pull request
Dec 21, 2020
…d objects Use of partial linking for offload on Linux has recently been removed in the driver (please see intel#2867), so there are no remaining uses of "oo" unbundling mode anymore. This patch cleans up support for this mode from the bundler tool to reduce amount of differences between intel/llvm branch and llvm.org. Signed-off-by: Sergey Dmitriev <[email protected]>
bader
pushed a commit
that referenced
this pull request
Jan 12, 2021
…d objects (#2927) Use of partial linking for offload on Linux has recently been removed in the driver (please see #2867), so there are no remaining uses of "oo" unbundling mode anymore. This patch cleans up support for this mode from the bundler tool to reduce amount of differences between intel/llvm branch and llvm.org. Signed-off-by: Sergey Dmitriev <[email protected]>
jsji
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ters` (#2867) Do not lose variable type in forward translation - take it from the already translated "untyped" variable. Original commit: KhronosGroup/SPIRV-LLVM-Translator@9207ef2aa150773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…archives
For Linux, we would use partial linking to generate the object that contained
the device binaries from a fat static archive. We are moving away from
using partial linking to provide a better overall solution that is the
same in regards to link behaviors for both Linux and Windows.
The change here will allow for the extraction of device binaries from
archives occur in the same manner as it does for Windows. We do full
extraction from the archives, and do a full llvm-link with those extracted
device binaries.