[SYCL] Fix handling of unpacked POD spec constants #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed calculating of offsets to scalar elements of composite spec constants by taking into account paddings, that might be instered into a struct by the compiler to make it elements aligned.
AlexeySachkov
commented
Dec 21, 2020
| @@ -213,26 +213,38 @@ getScalarSpecConstMetadata(const Instruction *I) { | |||
| /// Recursively iterates over a composite type in order to collect information | |||
| /// about its scalar elements. | |||
| void collectCompositeElementsInfoRecursive( | |||
There was a problem hiding this comment.
We need to have a unit-test for this change in the pass. Technically I can do that by looking into a properties file generated by sycl-post-link, but non-scalar properties are encoded using base64, so, it won't be an expressive test. However, this will be my plan if I didn't think of anything better. Any ideas are welcome
There was a problem hiding this comment.
I assumed the fix is needed urgently and the test will follow shortly, so I approved.
My idea would be adding logging to the spec constants pass and verifying the log output is expected. IIRC, some of passes use this approach.
romanovvlad
approved these changes
Dec 21, 2020
kbobrovs
approved these changes
Dec 22, 2020
AlexeySachkov
deleted the
private/asachkov/fix-handling-of-unpacked-composite-spec-constants
branch
jsji
pushed a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed calculating of offsets to scalar elements of composite spec constants
by taking into account paddings, that might be instered into a struct
by the compiler to make it elements aligned.