[Driver] Use clang-offload-deps tool for generating device dependencies #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndmitriev
force-pushed
the
public/sndmitriev/link-offload-deps
branch
from
f370ae6 to
371034f
Compare
This patch changes driver to use clang-offload-deps tool for generating dependence objects for SYCL and OpenMP programs when static fat libraries are used. Driver adds an additional link step on the host side to create host image which serves as an input for the clang-offload-deps tool. Dependence bitcode files produced by the tool are then compiled to objects where necessary and added to the device linker inputs. Signed-off-by: Sergey Dmitriev <[email protected]>
sndmitriev
force-pushed
the
public/sndmitriev/link-offload-deps
branch
from
371034f to
b6374c7
Compare
Use @llvm.used global variable for representing a reference for 'sycl' offloading kind. Signed-off-by: Sergey Dmitriev <[email protected]>
…bals Signed-off-by: Sergey Dmitriev <[email protected]>
sndmitriev
force-pushed
the
public/sndmitriev/link-offload-deps
branch
from
804616c to
ed4d6ec
Compare
mdtoguchi
reviewed
Dec 23, 2020
clang/lib/Driver/Driver.cpp
Outdated
| @@ -4742,6 +4774,28 @@ class OffloadingActionBuilder final { | |||
| return false; | |||
| } | |||
|
|
|||
| void addDeviceDependencies(ActionList &LinkerInputs) { | |||
There was a problem hiding this comment.
The name addDeviceDependencies threw me for a loop as it is similar to the existing addDeviceDepences. is there a better name we can use here?
There was a problem hiding this comment.
Does addDeviceLinkDependenciesFromHost look better?
kbobrovs
reviewed
Dec 23, 2020
Signed-off-by: Sergey Dmitriev <[email protected]>
kbobrovs
previously approved these changes
Dec 24, 2020
AGindinson
reviewed
Dec 28, 2020
AGindinson
previously approved these changes
Dec 28, 2020
Signed-off-by: Sergey Dmitriev <[email protected]>
sndmitriev
dismissed stale reviews from AGindinson, mdtoguchi, and kbobrovs
via
e8dd5a8
kbobrovs
approved these changes
Dec 29, 2020
AGindinson
approved these changes
Dec 29, 2020
|
Is it possible for somebody else to approve this patch while @bader is on vacation? |
romanovvlad
approved these changes
Dec 30, 2020
jsji
pushed a commit
that referenced
this pull request
Feb 25, 2025
For in-tree builds with shared libraries, setting the rpath not only works, but is required. Fixes #2906 Original commit: KhronosGroup/SPIRV-LLVM-Translator@7c0db925422d1f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes driver to use clang-offload-deps tool for generating
dependence objects for SYCL and OpenMP programs when static fat libraries
are used. Driver adds an additional link step on the host side to create
host image which serves as an input for the clang-offload-deps tool.
Dependence bitcode files produced by the tool are then compiled to
objects where necessary and added to the device linker inputs.
Signed-off-by: Sergey Dmitriev [email protected]