[SYCL][PI] Make the Plugin Interface tracing thread-safe #2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
changed the title
againull
force-pushed
the
multithread
branch
from
4b12d29 to
a54eb88
Compare
againull
force-pushed
the
multithread
branch
from
a54eb88 to
ec163a0
Compare
| @@ -106,6 +108,7 @@ class plugin { | |||
| private: | |||
| RT::PiPlugin MPlugin; | |||
| backend MBackend; | |||
| std::shared_ptr<std::mutex> TracingMutex; | |||
There was a problem hiding this comment.
Should this be
Suggested change
| std::shared_ptr<std::mutex> TracingMutex; | |
| std::shared_ptr<std::mutex> MTracingMutex; |
?
smaslov-intel
approved these changes
Dec 24, 2020
romanovvlad
reviewed
Dec 25, 2020
| @@ -106,6 +108,7 @@ class plugin { | |||
| private: | |||
| RT::PiPlugin MPlugin; | |||
| backend MBackend; | |||
| std::shared_ptr<std::mutex> TracingMutex; | |||
There was a problem hiding this comment.
Could you please clarify why std::mutex is wrapped with std::shared_ptr?
There was a problem hiding this comment.
Because mutex object cannot be copied.
jsji
pushed a commit
that referenced
this pull request
Jan 10, 2025
Adds support for SPIR-V OpBitcast instructions where the source is a pointer and the destination is not a pointer, and where the source is not a pointer and the destination is a pointer. This needs to be handled as a special case because the LLVM bitcast instruction does not support this. Handles bitcasts between pointers and scalar integers, which is supported by all SPIR-V versions, and pointers and vectors of integers, which is supported by SPIR-V 1.5 (though only for vectors of 32-bit integers). Original commit: KhronosGroup/SPIRV-LLVM-Translator@aafca810e5cd645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.