[SYCL][NFC] Minor update of upper limit attribute value #2953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates MaxValue of SYCLIntelSchedulerTargetFmaxMhz
attribute to be consistent with other FPGA attributes.
Before:
static unsigned getMaxValue() {
return 1048576;
After:
static unsigned getMaxValue() {
return 1024*1024;
The MaxValue(upper limit) is just an arbitrary high value.
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
approved these changes
Dec 25, 2020
jsji
pushed a commit
that referenced
this pull request
Jan 26, 2025
In reverse translation always use poison values except cases where we translate OpUndef. In other cases common sense was used to define where it is safe to replace undef to poison (e.g. in creating structures, regularization passes). This resolves #2953 and aligns us with the LLVM community in terms of generating IR. Original commit: KhronosGroup/SPIRV-LLVM-Translator@cec12d6cf46306d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates MaxValue of SYCLIntelSchedulerTargetFmaxMhz
attribute to be consistent with other FPGA attributes.
Before:
static unsigned getMaxValue() {
return 1048576;
After:
static unsigned getMaxValue() {
return 1024*1024;
The MaxValue(upper limit) is just an arbitrary high value.
Signed-off-by: Soumi Manna [email protected]