[SYCL] Fix excessive memory allocation for devices in the OpenCL plugin #2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin used to allocate memory for the number of devices equal to the combined size of returned devices rather than their number.
smaslov-intel
approved these changes
Jan 5, 2021
jsji
pushed a commit
that referenced
this pull request
Jan 26, 2025
bashbaug Member bashbaug commented 4 days ago See: https://github.khronos.org/SPIRV-Registry/extensions/EXT/SPV_EXT_arithmetic_fence.html Removes all internal enums for the unpublished SPV_INTEL_arithmetic_fence extension and uses the SPV_EXT_arithmetic_fence support in the headers instead. Registers the SPV_EXT_arithmetic_fence extension. Uses the SPV_EXT_arithmetic_fence extension if it is enabled, otherwise uses the SPV_INTEL_arithmetic_fence extension if it is enabled (for compatibility), otherwise ignores the LLVM arithmetic fence intrinsic (the ignoring part is not new). Updates the arithmetic fence test: Ensures that the right extension support is declared, depending on the enabled extensions. Ensures that the ArithmeticFenceEXT capability is declared when either extension is enabled. Note, the spelling for the capability is unconditionally the EXT version. Ensures that the OpArithmeticFenceEXT is present when either extension is enabled. Ensures that no extension, capability, or instruction is generated when neither extension is enabled. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a35a761c18874df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin used to allocate memory for the number of devices equal to
the combined size of returned devices rather than their number.