[XPTIFW] Enable in-tree builds #2959
Conversation
alexbatashev
requested review from
andykaylor,
bader,
tovinkere and
a team
as code owners
|
@intel/llvm-reviewers-runtime @tovinkere @andykaylor friendly ping |
|
@smaslov-intel Could you please review the patch? |
| @@ -14,17 +17,25 @@ if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) | |||
| set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Build type (default Release)" FORCE) | |||
| endif() | |||
|
|
|||
| project (xptifw) | |||
| if(MSVC) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc") | |||
There was a problem hiding this comment.
Please add a comment why building with /EHsc
There was a problem hiding this comment.
It is needed because of the change: "printf" -> "std::cout <<"
There was a problem hiding this comment.
can you elaborate even more and add this as a source code comment?
There was a problem hiding this comment.
Is it ok to do so in separate PR?
There was a problem hiding this comment.
Yes, sure. I approved this PR
|
@bader It seems the PR is waiting for your review, could you please do a review? |
Sure. For the future, please, request review via GitHub UI explicitly. |
This time Pull Request also includes reasonable fixes for warnings and disables targets, that are currently not buildable.