[SYCL] Fix -fno-sycl-early-optimizations behavior broken in pulldown. #2999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianqingw
requested review from
AGindinson,
elizabethandrews,
mdtoguchi and
premanandrao
as code owners
|
Should this have tests? Or is this just fixing failing tests because of incorrect pulldown? |
tianqingw
changed the title
Yeah, I forgot to add test. |
premanandrao
approved these changes
Jan 8, 2021
mdtoguchi
approved these changes
Jan 8, 2021
elizabethandrews
approved these changes
Jan 8, 2021
|
FYI: D83892 is reverted by https://reviews.llvm.org/rG7ad666798f12456d9e663e763e17e29007c3728d (Dec 23) and re-applied by https://reviews.llvm.org/rGce8c59e6af487f0b8786ae921aa926341f0ae04f (Jan 5). |
|
I suggest we integrate this fix to #3015, which includes the final version of the community change. |
|
I see that this fix is included into #3015, so I'm closing this one. |
jsji
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D83892 simplifies Clang option parsing, including that of
"-disable-llvm-passes", but inadvertently removes SYCL custom logic for it.
This patch reverts to the old way of handling "-disable-llvm-passes" and
restores the original behavior.