Skip to content

[SYCL] Fix plugin deinit order #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 19, 2021

Conversation

alexbatashev
Copy link
Contributor

Scheduler may hold references to active queues, which upon destruction
may call PI APIs. To avoid potential clashes, acquire a reference on plugins
and only perform tear down after scheduler is gone.

Alexander Batashev added 3 commits January 13, 2021 15:22
Scheduler may hold references to active queues, which upon destruction
may call PI APIs. To avoid potential clashes, acquire a reference on plugins
and only perform tear down after scheduler is gone.
@alexbatashev alexbatashev marked this pull request as ready for review January 19, 2021 10:48
@alexbatashev alexbatashev requested a review from a team as a code owner January 19, 2021 10:48
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correcting the shutdown order.

@romanovvlad romanovvlad merged commit 8eb00d7 into intel:sycl Jan 19, 2021
@alexbatashev alexbatashev deleted the fix_plugin_deinit_order branch July 28, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants