[SYCL][ESIMD] add indirect read and write methods #3039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kychendev @kbobrovs please review and merge timely |
kychendev
reviewed
Jan 15, 2021
| sycl::INTEL::gpu::vector_type_t<T, M> Result; | ||
| for (int i = 0; i < M; ++i) { | ||
| uint16_t EltOffset = Offset[i] / sizeof(T); | ||
| assert(Offset[i] % sizeof(T) == 0); |
There was a problem hiding this comment.
Could add safety check here and report error on out-of-bound access.
kychendev
reviewed
Jan 15, 2021
kychendev
reviewed
Jan 15, 2021
kychendev
reviewed
Jan 15, 2021
Signed-off-by: Gang Y Chen <[email protected]>
cmc-rep
force-pushed
the
cmc-rep-change
branch
from
2e086c3 to
8ce95fa
Compare
|
@kychendev @kbobrovs , update is ready for review |
kychendev
approved these changes
Jan 17, 2021
|
@konst, could you help with this merge? |
|
@kbobrovs, could you help with this merge |
kbobrovs
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen [email protected]