[SYCL] Added a new category for device binary properties #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2021
kbobrovs
reviewed
Jan 22, 2021
smaslov-intel
previously approved these changes
Jan 22, 2021
bader
previously approved these changes
Jan 22, 2021
kbobrovs
previously approved these changes
Jan 26, 2021
romanovvlad
requested changes
Jan 27, 2021
DenisBakhvalov
dismissed stale reviews from kbobrovs, bader, and smaslov-intel
via
d0939fc
romanovvlad
previously approved these changes
Jan 27, 2021
kbobrovs
approved these changes
Jan 28, 2021
kbobrovs
suggested changes
Jan 29, 2021
| @@ -187,6 +187,7 @@ class PropertySetRegistry { | |||
| "SYCL/composite specialization constants"; | |||
| static constexpr char SYCL_DEVICELIB_REQ_MASK[] = "SYCL/devicelib req mask"; | |||
| static constexpr char SYCL_KERNEL_PARAM_OPT_INFO[] = "SYCL/kernel param opt"; | |||
| static constexpr char SYCL_IS_ESIMD_IMAGE[] = "SYCL/is ESIMD image"; | |||
There was a problem hiding this comment.
@DenisBakhvalov, as we agreed, can you please change the category name for this to something like SYCL/misc or SYCL/binary image?
@DenisBakhvalov, please see comment above. If believe the category name change is still pending, right? |
@kbobrovs Yes, I'm working on it. |
DenisBakhvalov
changed the title
romanovvlad
approved these changes
Feb 1, 2021
|
The approval from @smaslov-intel is required. There were changes in the code he owns since his latest review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new category for general properties of device binary images. And it adds an API to retrieve properties from that common category.