[SYCL] Add code examples for all SYCL Function Attributes #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have added code examples for some of the function attributes. This patch adds code examples for remaining SYCL function attributes that we did not have before to improve the documentation about attributes. Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
Signed-off-by: Soumi Manna <[email protected]>
| [[intel::max_global_work_dim(N)]] void operator()() const {} | ||
| }; | ||
|
|
||
| A kernel with max_global_work_dim(0) must be invoked with a |
There was a problem hiding this comment.
Missing backticks around max_global_work_dim(0)
Signed-off-by: Soumi Manna <[email protected]>
|
LGTM! |
|
Thanks for the reviews. |
iclsrc
pushed a commit
that referenced
this pull request
Apr 21, 2025
Update after llvm-project commit 146ad71 ("[IR] Deprecate PointerType::get/getUnqual pointee type overload (#134517)", 2025-04-06). Original commit: KhronosGroup/SPIRV-LLVM-Translator@2c6186986a285e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added code examples for some of the function attributes.
This patch adds code examples for remaining SYCL function attributes
that we did not have before to improve the documentation about
attributes.
Signed-off-by: Soumi Manna [email protected]