Skip to content

[SYCL] Support parallel_for() accepting many reductions #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 5, 2021

Conversation

v-klochkov
Copy link
Contributor

@v-klochkov v-klochkov commented Jan 30, 2021

The LIT test testing this change-set: intel/llvm-test-suite#131

Signed-off-by: Vyacheslav N Klochkov [email protected]

@v-klochkov v-klochkov requested a review from Pennycook January 30, 2021 05:01
@v-klochkov v-klochkov requested a review from a team as a code owner January 30, 2021 05:01
Pennycook
Pennycook previously approved these changes Feb 1, 2021
Pennycook
Pennycook previously approved these changes Feb 2, 2021
@v-klochkov
Copy link
Contributor Author

I added a LIT test for this patch: intel/llvm-test-suite#131

An additional test-case accepting lambda-func instead of functors showed a minor issue in this implementation.
If reduction_impl::binary_operation is a lambda, then the whole reduction_impl (and std::tuple including it) cannot
be used to obtain a typename for a kernel.
The issue is fixed in 205c124

@vladimirlaz
Copy link
Contributor

I added a LIT test for this patch: intel/llvm-test-suite#131

An additional test-case accepting lambda-func instead of functors showed a minor issue in this implementation.
If reduction_impl::binary_operation is a lambda, then the whole reduction_impl (and std::tuple including it) cannot
be used to obtain a typename for a kernel.
The issue is fixed in 205c124

Please add this info to commit message as requested in https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md

vladimirlaz
vladimirlaz previously approved these changes Feb 2, 2021
@vladimirlaz vladimirlaz requested a review from Pennycook February 3, 2021 08:38
Pennycook
Pennycook previously approved these changes Feb 3, 2021
@v-klochkov v-klochkov dismissed stale reviews from Pennycook and vladimirlaz via efcd7e1 February 4, 2021 00:48
v-klochkov added a commit to v-klochkov/llvm-test-suite that referenced this pull request Feb 4, 2021
This test verifies the following change-set in compiler: intel/llvm#3123

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
vladimirlaz
vladimirlaz previously approved these changes Feb 4, 2021
Pennycook
Pennycook previously approved these changes Feb 4, 2021
@v-klochkov v-klochkov dismissed stale reviews from Pennycook and vladimirlaz via d1fbc3b February 4, 2021 18:33
@bader bader merged commit c042f9e into intel:sycl Feb 5, 2021
@v-klochkov v-klochkov deleted the public_vklochkov_reduction_N_vars_perf branch February 5, 2021 16:28
vladimirlaz pushed a commit to intel/llvm-test-suite that referenced this pull request Feb 8, 2021
This test verifies the following change-set in compiler: intel/llvm#3123

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…el/llvm-test-suite#131)

This test verifies the following change-set in compiler: intel#3123

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
iclsrc pushed a commit that referenced this pull request May 12, 2025
- Implemented the TODO in the visitCallEnqueueKernel function
- Takes param size and align from literal block
- If dynamic allocation is used store instructions are processed to
obtain size and align
- Modified test

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@ff7db6ef1c71860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants