[SYCL][NFC] Minor update for mutual diagnostic function of different work_group_size attributes #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work_group_size attributes
This patch
1. fixes typo
2. removes redundant comments (we have disabled swapping dimension values of WorkGroupAttr
arguments for semantic checks on intel#2962)
3. Hoist the logic from the second if into the above if (AttrValue == 0)
Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
elizabethandrews
approved these changes
Feb 1, 2021
premanandrao
approved these changes
Feb 1, 2021
|
Thanks everyone for the reviews. |
iclsrc
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
arguments for semantic checks on [SYCL] [FPGA] Disable swapping dimension values of WorkGroupAttr arguments for semantic checks #2962)
Signed-off-by: Soumi Manna [email protected]