[SYCL] Get rid of ifunc GNU extension uses #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
previously approved these changes
Jul 14, 2019
keryell
reviewed
Jul 15, 2019
|
This patch needs re-base - I see some conflicts right now when try using cherry-pick of this commit. |
Signed-off-by: Sergey V Maslov <[email protected]>
|
Rebased and addressed comments.
The key changes are into pi* dispatch to not use GNU "ifunc" extension for call forwarding. |
bader
approved these changes
Jul 16, 2019
keryell
reviewed
Jul 16, 2019
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change resolution of PI interfaces from load-time to run-time. This is a step towards real plugins system, but more importantly it gets rid of "ifunc" GNU extension to be able to build on Windows. The key changes are in the definitions of "dispatch" in pi.hpp and pi_opencl.cpp
Signed-off-by: Sergey V Maslov [email protected]