[SYCL][NFC] Code cleanup revealed by self-build. #3153
Conversation
Remove redundant false case in switch statement following: https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
zahiraam
requested review from
AlexeySachkov,
elizabethandrews,
kbobrovs and
premanandrao
as code owners
clang/lib/Sema/SemaSYCL.cpp
Outdated
| @@ -3477,7 +3481,6 @@ static const char *paramKind2Str(KernelParamKind K) { | |||
| CASE(std_layout); | |||
| CASE(sampler); | |||
| CASE(pointer); | |||
| default: | |||
| return "<ERROR>"; | |||
There was a problem hiding this comment.
Shouldn't the return "" statement be moved outside the switch block?
There was a problem hiding this comment.
Good catch! Updated it. Thanks.
There was a problem hiding this comment.
BTW, I was wondering how to guard against forgetting to add a handling for a new enum value when it is added. Clang is consistent here and also issues an error in such case error: enumeration value 'green' not handled in switch [-Werror,-Wswitch] .
post-link approved
Remove redundant false case in switch statement following: https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
clang/lib/Sema/SemaSYCL.cpp
Outdated
| } | ||
| return "<ERROR>"; |
There was a problem hiding this comment.
Please fix the clang-format error about indentation here. But otherwise, looks good.
modified: clang/lib/Sema/SemaSYCL.cpp
|
That switch-case macro change in SemaSYCL.cpp has now disappeared. Did you split that out? |
I had a conflict resolution and I have done it on this page! May be I should fix that in my ws. |
modified: clang/lib/Sema/SemaSYCL.cpp
|
Can someone please review this? Thanks. |
|
LGTM but code owners @AlexeySachkov @kbobrovs needs to approve. |
Sorry @zahiraam, I missed getting back to this after the intermittent test failure issue. |
No worries. I have more reviews coming and wanted this one to be merged in before. Thanks. |
FYI: it's not required by https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md anymore. |
Remove redundant false case in switch statement following: https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
Remove redundant false case in switch statement following:
https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations