[SYCL] Temporarily restore event deps in in-order queues for Level Zero #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the enqueued operations are implemented directly in the Level Zero plugin (e.g. map/unmap) and their implementation does not satisfy in-order queue requirements, leading to incorrect behaviour if the event dependencies that should be redundant are dropped. Restore these event dependencies until this is fixed in the Level Zero plugin.
|
The corresponding LIT test is already disabled with Level Zero, I've created a PR that adjusts a comment in the test to mention this issue intel/llvm-test-suite#139 |
romanovvlad
previously approved these changes
Feb 9, 2021
romanovvlad
approved these changes
Feb 9, 2021
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Feb 10, 2021
…#139) The test was initially disabled due to a bug in the Level Zero plugin that led to a hang, which has already been fixed in intel/llvm#3081 Despite that, the test should stay disabled since the tested functionality is to be temporarily turned off for Level Zero in intel/llvm#3188
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Feb 16, 2021
…ro (intel#3188) Some of the enqueued operations are implemented directly in the Level Zero plugin (e.g. map/unmap) and their implementation does not satisfy in-order queue requirements, leading to incorrect behaviour if the event dependencies that should be redundant are dropped. Restore these event dependencies until this is fixed in the Level Zero plugin.
pvchupin
pushed a commit
that referenced
this pull request
Apr 1, 2021
Adds in-order queue semantics. Reverts [SYCL] Temporarily restore event deps in in-order queues for Level Zero #3188 Signed-off-by: rbegam [email protected]
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…intel/llvm-test-suite#139) The test was initially disabled due to a bug in the Level Zero plugin that led to a hang, which has already been fixed in intel#3081 Despite that, the test should stay disabled since the tested functionality is to be temporarily turned off for Level Zero in intel#3188
jsji
pushed a commit
that referenced
this pull request
Jun 17, 2025
… unsigned (#3188) Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR. Adding const to pointer arg aligns with OpenCL spec and allows const pointer input. Original commit: KhronosGroup/SPIRV-LLVM-Translator@96f5ade29c9088e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the enqueued operations are implemented directly in the Level
Zero plugin (e.g. map/unmap) and their implementation does not satisfy
in-order queue requirements, leading to incorrect behaviour if the event
dependencies that should be redundant are dropped.
Restore these event dependencies until this is fixed in the Level Zero
plugin.