[NFC] Code cleanup revealed by self-build. #3191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahiraam
requested review from
AlexeySachkov,
AlexeySotkin,
DenisBakhvalov and
kbobrovs
as code owners
llvm-spirv/lib/SPIRV/SPIRVToOCL.cpp
Outdated
Comment on lines
540
to
542
| default: | ||
| llvm_unreachable("Unsupported built-ins representation"); | ||
| return nullptr; |
There was a problem hiding this comment.
This change should be upstreamed to KhronosGroup/SPIRV-LLVM-Translator GitHub repo (as well as the rest of changed in llvm-spirv directory)
There was a problem hiding this comment.
Do I need to revert this or leave it and upstream to Khronos repo too?
There was a problem hiding this comment.
Reverted those files. Thanks.
DenisBakhvalov
previously approved these changes
Feb 9, 2021
zahiraam
dismissed stale reviews from DenisBakhvalov and kbobrovs
via
ed46392
v-klochkov
approved these changes
Feb 9, 2021
kbobrovs
approved these changes
Feb 10, 2021
jsji
pushed a commit
that referenced
this pull request
Jun 17, 2025
This is a follow-up to #2346 Original commit: KhronosGroup/SPIRV-LLVM-Translator@6f53bc4f7ce95b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.