[SYCL] Deprecate old OpenCL interop APIs in SYCL 2020 mode #3194
Conversation
Co-authored-by: Alexey Sachkov <[email protected]>
|
I have a quick question, I can see that the program class is going to be deprecated but I didn't find neither |
* upstream/sycl: (1804 commits) [SYCL] SYCL 2020 backend interoperability part 1 (intel#3354) [Driver][SYCL] Address issue when unbundling for non-FPGA archive (intel#3366) [SYCL][Doc] Update compiler options descriptions (intel#3340) [SYCL] Update ABI dump tool to disable checks with libcxx by default (intel#3370) [SYCL] Update the way we handle -sycl-std= based on community review feedback (intel#3371) [SYCL] Move tests to llvm-test-suite (intel#3359) [SYCL][PI][L0] Revert copy batching from intel#3232 (intel#3363) [SYCL] Remove unsupported option. [SYCL] Fix pragma setting in sycl-post-link (intel#3358) [SYCL] Add ITT annotation instructions (intel#3299) [SYCL] Propagate attributes of original kernel to wrapper kernel generated for range-rounding (intel#3306) [BuildBot] Uplift GPU RT version for Linux to 21.09.19150 (intel#3316) [SYCL] Retain PI events until they have signaled (intel#3350) [SYCL] Add caching when using interop constructor (intel#3327) Add ITT stubs and wrappers for SPIR-V devices (intel#3279) [SYCL] Add zero argument version of buffer::reinterpret() for SYCL 2020 (intel#3333) [SYCL] Restore old behavior of get() method (intel#3356) [Driver][SYCL][FPGA] Improve FPGA AOT when using Triple (intel#3330) [SYCL] Revert support for pinned_host_memory extension in Level-Zero backend. Make it a NOP (intel#3349) [SYCL] Remove redundant build options processing (intel#3342) ...
alexbatashev
dismissed stale reviews from AlexeySachkov, romanovvlad, and sergey-semenov
via
193049d
|
Replacements for the interop APIs have been merged. I updated patch to exclude program class deprecation. I'll add the warning when kernel_bundle is merged. |
Co-authored-by: Pavel Chupin <[email protected]>
| @@ -73,6 +74,7 @@ macro(add_sycl_unittest_with_device test_dirname link_variant) | |||
| -DGTEST_LANG_CXX11=1 | |||
| -DGTEST_HAS_TR1_TUPLE=0 | |||
| -D__SYCL_BUILD_SYCL_DLL | |||
| -DSYCL2020_DISABLE_DEPRECATION_WARNINGS | |||
There was a problem hiding this comment.
We still use SYCL 1.2.1 APIs inside runtime and tests. To avoid build failures due to -Werror, I suppressed these warnings for compiler build.
There was a problem hiding this comment.
Ok. Maybe I'm missing something, but is it a right level of Makefiles to add this flag?
It looks like it's been added for all LIT tests? Is it possible to add flag individually to tests which are really designed to test older 1.2.1 API rather than using it by accident?
I'd like us to stop adding more tests with 1.2.1 APIs.
There was a problem hiding this comment.
@pvchupin no, it's only for unit tests. We build them as part of compiler and link with the runtime statically, because many internal symbols are not exported from libsycl.so (to avoid accidental linkage of user code with our private interfaces). Other LIT tests (those in sycl/test/ or llvm-test-suite) won't be affected by this option.
There was a problem hiding this comment.
I've updated tests to only disable warnings in the TUs, that use interop API
alexbatashev
dismissed stale reviews from romanovvlad and sergey-semenov
via
71009cc
|
@alexbatashev, am I right that pre-commit issues are not related to this PR and we expect them to be addressed by intel/llvm-test-suite#195? |
that's correct |
These warnings can be suppressed by
SYCL2020_DISABLE_DEPRECATION_WARNINGSmacro or by setting-sycl-std=2017or-sycl-std=1.2.1.Also a new macro
SYCL_DISABLE_DEPRECATION_WARNINGSis introduced, to disable all deprecation warnings completely (including SYCL 1.2.1 deprecation warnings).