[SYCL] Store the constant expression value into the ConstantExpr object. #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be an oversight from the community changes made in https://reviews.llvm.org/D63376, where we would calculate the constant expression value but failed to store it into the ConstantExpr object.
AaronBallman
requested review from
elizabethandrews and
premanandrao
as code owners
|
FWIW, I'm definitely not fixing any formatting errors in the AST dumping test files. Many of those are whitespace sensitive and trying to reformat those files would be risky and likely to cause merge conflicts with upstream. I'm uncertain of how to convey this to the CI system though. |
|
@AaronBallman, feel free to ignore clang-format-check. I haven't disable it for clang tests yet. |
LoL, I like how we both had the same opinion at the same time on that. :-D |
|
Closing this PR as it sounds like we'd prefer to land this upstream and then cherry-pick the changes to SYCL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be an oversight from the community changes made in
https://reviews.llvm.org/D63376, where we would calculate the constant
expression value but failed to store it into the ConstantExpr object.
I am also making similar changes upstream, but this functionality is needed
by #3169.