Store the calculated constant expression value into the ConstantExpr … #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object With https://reviews.llvm.org/D63376, we began storing the APValue directly into the ConstantExpr object so that we could reuse the calculated value later. However, it missed a case when not in C++11 mode but the expression is known to be constant.
erichkeane
requested review from
elizabethandrews and
premanandrao
as code owners
|
LGTM -- we're going to ignore the clang-format issues because they're within whitespace-sensitive test files. |
AaronBallman
approved these changes
Feb 11, 2021
elizabethandrews
approved these changes
Feb 11, 2021
|
@bader this is a cherry-pick from intel/llvm. We need it for a couple of pending patches, which is why we cherry-picked. |
You mean from llvm/llvm-project? |
I hope #3205 fixes clang-format check. |
Yes, that is the case. |
Yes. Sorry. It is from llvm/llvm-project |
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Feb 16, 2021
…object (intel#3204) With https://reviews.llvm.org/D63376, we began storing the APValue directly into the ConstantExpr object so that we could reuse the calculated value later. However, it missed a case when not in C++11 mode but the expression is known to be constant. Co-authored-by: Aaron Ballman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…object
With https://reviews.llvm.org/D63376, we began storing the APValue
directly into the ConstantExpr object so that we could reuse the
calculated value later. However, it missed a case when not in C++11
mode but the expression is known to be constant.