[ESIMD] Move ESIMD-specific passes to sycl-post-link #3222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only a finalizing patch that flips the switch for doing ESIMD-specific transformations in sycl-post-link after device code splitting. All the preliminary patches have already been committed. ESIMD-specific passes have been removed from BackendUtil.cpp as they are now done in sycl-post-link.
DenisBakhvalov
requested review from
AGindinson,
elizabethandrews and
premanandrao
as code owners
premanandrao
previously approved these changes
Feb 17, 2021
DenisBakhvalov
dismissed stale reviews from mdtoguchi and premanandrao
via
bf9d64d
|
@DenisBakhvalov, please, resolve merge conflicts. |
I updated the description of the PR. |
mdtoguchi
approved these changes
Feb 19, 2021
AlexeySachkov
approved these changes
Feb 19, 2021
|
@DenisBakhvalov, please, take a look at pre-commit failure. |
Restarted the build |
kbobrovs
approved these changes
Feb 21, 2021
| // TODO: previously code generation and ESIMD lowering was | ||
| // a part of the same %clang_cc1 invocation, but now it is | ||
| // separate. So, we can split this test into 2, where one | ||
| // will be testing code generation and the second ESIMD lowering. |
|
@bader, please merge if no objections. |
premanandrao
approved these changes
Feb 22, 2021
jsji
added a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a continuation of prior series of patches to allow
having ESIMD and regular SYCL kernels in the same source code
and in the same program.
To mix two types of kernels we need to postpone lowering of
ESIMD specific constructs and do that after we split ESIMD from
regular SYCL code, which is done in sycl-post-link.
This is a finalizing patch that only flips the switch for
doing ESIMD-specific transformations in sycl-post-link
and removes those passes from the common optimization
pipeline in FE (BackendUtil.cpp). All the preliminary patches
have already been committed.
The test code that is enabled by this change can be found here:
intel/llvm-test-suite#141