[SYCL] Add Level-Zero interop with specification of ownership #3231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you have changed the L0 interop API, it seems like you should also update the documentation at "sycl/doc/extensions/LevelZeroBackend/LevelZeroBackend.md". |
againull
reviewed
Feb 19, 2021
Sure, I've updated the doc now. |
|
A new E2E test is coming in intel/llvm-test-suite#153 |
gmlueck
reviewed
Feb 22, 2021
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
|
The failure of SYCL/Plugins/level-zero-interop.cpp in precommit testing is expected and is due to a test bug. The fix is coming in: |
Signed-off-by: Sergey V Maslov <[email protected]>
smaslov-intel
force-pushed
the
ownership
branch
from
5094774 to
3b97d3c
Compare
|
LGTM |
gmlueck
previously approved these changes
Feb 22, 2021
againull
previously approved these changes
Feb 24, 2021
smaslov-intel
changed the title
Signed-off-by: Sergey V Maslov <[email protected]>
smaslov-intel
dismissed stale reviews from againull, gmlueck, and bso-intel
via
068a1f1
smaslov-intel
changed the title
|
@mkinsner, @jbrodman , @romanovvlad please review |
gmlueck
reviewed
Feb 26, 2021
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
gmlueck
approved these changes
Feb 26, 2021
|
Waiting on code owner review from @intel/llvm-reviewers-cuda, @intel/llvm-reviewers-runtime , @intel/dpcpp-specification-reviewers! |
romanovvlad
reviewed
Mar 1, 2021
romanovvlad
approved these changes
Mar 1, 2021
|
@jbrodman Could you please review? |
jbrodman
approved these changes
Mar 2, 2021
jsji
pushed a commit
that referenced
this pull request
Jun 17, 2025
Extend KhronosGroup/SPIRV-LLVM-Translator#2339 to support also `OpGroupNonUniformShuffle`, `OpGroupNonUniformShuffleUp`, and `OpGroupNonUniformShuffleXor`. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a61deeef1dd3e35
vmaksimo
pushed a commit
that referenced
this pull request
Jun 30, 2025
Extend KhronosGroup/SPIRV-LLVM-Translator#2339 to support also `OpGroupNonUniformShuffle`, `OpGroupNonUniformShuffleUp`, and `OpGroupNonUniformShuffleXor`. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a61deeef1dd3e35
mikolaj-pirog
pushed a commit
that referenced
this pull request
Jul 1, 2025
Extend KhronosGroup/SPIRV-LLVM-Translator#2339 to support also `OpGroupNonUniformShuffle`, `OpGroupNonUniformShuffleUp`, and `OpGroupNonUniformShuffleXor`. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a61deeef1dd3e35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Level-Zero backend specified assuming ownership of the native handles used in the interoperability.
There was however request made that this is not sufficient in all cases, e.g. when some memory was created outside SYCL RT in some Level-Zero Context, then working with that memory should always be within the same context. Thus if anyone wanted to "return" something back from SYCL, then the context should still exist and be the same.
This patch only does for context, but probably we'd need to deal with other objects too at some point.
Signed-off-by: Sergey V Maslov [email protected]