[SYCL] Fix get_native() and add get_backend() accordingly to the specification and test for the get_native() #3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ification Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
s-kanaev
reviewed
Feb 20, 2021
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
maximdimakov
changed the title
s-kanaev
reviewed
Mar 3, 2021
There was a problem hiding this comment.
Looks good to me.
@smaslov-intel, could you, please, review. I believe, you are more common with interoperability than me.
alexbatashev
suggested changes
Mar 5, 2021
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
|
@alexbatashev , @smaslov-intel can you review, please? |
alexbatashev
reviewed
Mar 9, 2021
smaslov-intel
suggested changes
Mar 9, 2021
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
smaslov-intel
previously approved these changes
Mar 11, 2021
smaslov-intel
approved these changes
Mar 11, 2021
alexbatashev
approved these changes
Mar 12, 2021
s-kanaev
reviewed
Mar 22, 2021
| @@ -3897,6 +3897,7 @@ _ZNK2cl4sycl15interop_handler12GetNativeMemEPNS0_6detail16AccessorImplHostE | |||
| _ZNK2cl4sycl15interop_handler14GetNativeQueueEv | |||
| _ZNK2cl4sycl16default_selectorclERKNS0_6deviceE | |||
| _ZNK2cl4sycl20accelerator_selectorclERKNS0_6deviceE | |||
| _ZNK2cl4sycl5event11get_backendEv | |||
There was a problem hiding this comment.
Should minor/patch version of library be increased according to ABI policy?
There was a problem hiding this comment.
No, it'll be increased before release is tagged.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 25, 2023
OpenCL interop spec basically says that each "conversion" must adjust reference counter of the underlying object. Many of the interop interfaces had been fixed in intel#3236 but the majority of the kernel_bundle feature was implemented after that and made the same omission. I'm not sure if that is the best way to fix it though. Another alternative would be to move all these retains into the OpenCL PI plugin.
bader
pushed a commit
that referenced
this pull request
Mar 2, 2023
OpenCL interop spec basically says that each "conversion" must adjust reference counter of the underlying object. Many of the interop interfaces had been fixed in #3236 but the majority of the kernel_bundle feature was implemented after that and made the same omission. I'm not sure if that is the best way to fix it though. Another alternative would be to move all these retains into the OpenCL PI plugin.
iclsrc
pushed a commit
that referenced
this pull request
Jun 17, 2025
Update a test after llvm-project commit 28bda77 ("Introduce MCAsmInfo::UsesSetToEquateSymbol and prefer = to .set", 2025-06-11). Original commit: KhronosGroup/SPIRV-LLVM-Translator@46f225a7d0aa111
iclsrc
pushed a commit
that referenced
this pull request
Jun 30, 2025
Update a test after llvm-project commit 28bda77 ("Introduce MCAsmInfo::UsesSetToEquateSymbol and prefer = to .set", 2025-06-11). Original commit: KhronosGroup/SPIRV-LLVM-Translator@46f225a7d0aa111
mikolaj-pirog
pushed a commit
that referenced
this pull request
Jul 1, 2025
Update a test after llvm-project commit 28bda77 ("Introduce MCAsmInfo::UsesSetToEquateSymbol and prefer = to .set", 2025-06-11). Original commit: KhronosGroup/SPIRV-LLVM-Translator@46f225a7d0aa111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free get_native() method must call retain method for some classes when backend is opencl accordingly to the specification.
Also for these classes there must be get_backend() method.
Test for get_backend() : intel/llvm-test-suite#162