[SYCL][GDB] Relax xmethod script template arg handling #3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on namespace inlining the template argument string may end being "sycl:id<1>" or just "id<1>" rather than full "cl::sycl::id<1>" currently expected. Ideally a proper type lookup should happen, however, right now GDB does not support inline namespaces so such lookup would always fail. This patch relaxes regex matching instead as a compromise solution. It does not seem possible to test this change within this repository, unfortunately. It was manually verified at the moment of submission and will be caught eventually by the debugger tests in case of regressions.
alexbatashev
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another minor tweak to xmethod script.