[SYCL][FPGA][NFC] Fix num_simd_work_items and reqd_work_group_size argument check #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check This patch fixes intel#3252. According to https://www.intel.com/content/www/us/en/programmable/documentation/mwh1391807965224.html#mwh1391807939093 (section : 5.2.13. Specifying Number of SIMD Work-Items): Important: Introduce the num_simd_work_items attribute in conjunction with the reqd_work_group_size attribute. The num_simd_work_items attribute you specify must evenly divide the work-group size you specify for the reqd_work_group_size attribute. Based on discussion, the requirement applies only for X argument of reqd_work_group_size attribute. Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
smanna12
changed the title
AaronBallman
reviewed
Mar 1, 2021
Signed-off-by: Soumi Manna <[email protected]>
Thanks Aaron. |
|
Can i get a review from @premanandrao / @elizabethandrews? Thanks. |
premanandrao
previously approved these changes
Mar 2, 2021
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
|
@premanandrao / @elizabethandrews , could you please review the PR before merge conflicts happen again? |
| @@ -2421,8 +2421,8 @@ device kernel, the attribute is not ignored and it is propagated to the kernel. | |||
| If the`` intel::reqd_work_group_size`` or ``cl::reqd_work_group_size`` | |||
| attribute is specified on a declaration along with a | |||
| intel::num_simd_work_items attribute, the work group size attribute | |||
| arguments must all be evenly divisible by the argument specified in | |||
| the ``intel::num_simd_work_items`` attribute. | |||
| argument (the first argument) must be evenly divisible by the argument specified | |||
There was a problem hiding this comment.
For SYCL code isn't this supposed to be the last argument? From the bug report, I thought this attribute is specified as reqd_work_group_size(Z,Y,X) where X is the last argument and must be evenly divisible.
There was a problem hiding this comment.
This will be X - first argument and must be evenly divisible
premanandrao
reviewed
Mar 5, 2021
Signed-off-by: Soumi Manna <[email protected]>
Thank you, I have added comments and updated tests (used different arguments values for X and Z to avoid confusion here). |
Signed-off-by: Soumi Manna <[email protected]>
premanandrao
approved these changes
Mar 5, 2021
smanna12
added a commit
to smanna12/llvm
that referenced
this pull request
Mar 10, 2021
…gument check The order of the arguments to reqd_work_group_size in SYCL and OpenCL are reversed. In the OpenCL syntax, reqd_work_group_size(X,Y,Z), X is the index that increments the fastest, followed by Y, then Z. If we preserve that definition of X, Y, and Z, then in SYCL the attribute is specified as reqd_work_group_size(Z,Y,X). This gets more complicated in the case where fewer than three arguments are provided. In such a case it's not the "X" argument that is omitted (by the definitions of X, Y, and Z above) it's the Z dimension that's omitted. So the two argument version has the syntax reqd_work_group_size(Y,X). Similarly, the one argument variant has syntax reqd_work_group_size(X). This patches fixes the problem on intel#3275 where we checked the wrong argument. In SYCL, the num_simd_work_items must evenly divide the last argument to reqd_work_group_size regardless of how many arguments req_work_group_size has. Signed-off-by: Soumi Manna <[email protected]>
bader
pushed a commit
that referenced
this pull request
May 16, 2021
…t check (#3728) The arguments to reqd_work_group_size are ordered based on which index increments the fastest. In OpenCL, the first argument is the index that increments the fastest, and in SYCL, the last argument is the index that increments the fastest. In OpenCL, all three arguments are required. In SYCL, the attribute accepts either one, two, or three arguments; in each form, the last (or only) argument is the index that increments fastest. The number of arguments passed to the attribute must match the dimensionality of the kernel the attribute is applied to. If the reqd_work_group_size attribute is specified on a declaration along with num_simd_work_items, the required work group size specified by num_simd_work_items attribute must evenly divide the index that increments fastest in the reqd_work_group_size attribute. This patches fixes the problem on #3275 where we checked the wrong argument for SYCL and OpenCL attributes. Signed-off-by: Soumi Manna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #3252.
According to https://www.intel.com/content/www/us/en/programmable/documentation/mwh1391807965224.html#mwh1391807939093 (section : 5.2.13. Specifying Number of SIMD Work-Items):
Important: Introduce the num_simd_work_items attribute in conjunction with the reqd_work_group_size attribute. The num_simd_work_items attribute you specify must evenly divide the work-group size you specify for the reqd_work_group_size attribute.
Based on discussion, the requirement applies only for X argument of reqd_work_group_size attribute.
Signed-off-by: Soumi Manna [email protected]