[SYCL] Add implementation of kernel_bundle support. Part 1. #3278
Conversation
This patch adds most of declarations of kernel_bundle related APIs. Most of the logic of this patch is in making so APIs that have template parameters call corresponding library APIs that have no template parameters.
| @@ -0,0 +1,572 @@ | |||
| //==------- kernel_bundle.hpp - SYCL kernel_bundle and free functions ------==// | |||
| // | |||
There was a problem hiding this comment.
Do not add a test in this patch since not sure if it makes a lot of seance to prepare "compile-only" test which will be replaced anyway.
| #include <memory> | ||
| #include <vector> | ||
|
|
||
| __SYCL_INLINE_NAMESPACE(cl) { |
There was a problem hiding this comment.
Why do we put SYCL-2020 feature in cl::sycl namespace instead of sycl?
There was a problem hiding this comment.
Haven't thought about it. Since cl namespace is inline one it should not be a big issue, do you agree?
There was a problem hiding this comment.
This seems to be a bug which should be fixed in any case.
There was a problem hiding this comment.
It could be a DPC++ extension... Just use old-style programming but with new features.
On the other hand, in SYCL 2020, ::cl should not have any special meaning when #include <sycl/sycl.hpp>, so it would be bad to have some user code failing to compile just because ::cl is used in the program in an innocent OpenCL-unrelated way.
This patch adds most of declarations of kernel_bundle related APIs.
Most of the logic of this patch is in making so APIs that have
template parameters call corresponding library APIs that have no
template parameters.