[SYCL][Driver] Fix sycl_esimd option #3313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCL option did not set correctly and was lost during pulldown conflict here: intel@a52d3d3 This patch replaces OptInFFlag with BoolFOption ans sets the option correctly. Signed-off-by: Soumi Manna <[email protected]>
|
Here are some notes for the reviewers: There is already a test for "-fsycl-explicit-simd" option inside sycl-offload.c file, so I did not add any test here. We had this before a52d3d3: def fsycl_esimd : Flag<["-"], "fsycl-explicit-simd">, Group<sycl_Group>, Flags<[CC1Option, NoArgumentUnused, CoreOption]>, |
Thanks Mike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL option did not set correctly and was lost during pulldown
conflict here: a52d3d3
This patch replaces OptInFFlag with BoolFOption and sets the option correctly.
Signed-off-by: Soumi Manna [email protected]