Skip to content

[SYCL] Allow non-evaluated globals to be used in a kernel. #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

erichkeane
Copy link
Contributor

As requested to support SYCL-2020 specialization constants, this makes
our global variable diagnostics not happen unless it is in a runtime
evaluated context.

This is OK, because the SYCL standard prohibits ODR uses, of which
non-runtime-evaluated uses are not.

As requested to support SYCL-2020 specialization constants, this makes
our global variable diagnostics not happen unless it is in a runtime
evaluated context.
Erich Keane added 2 commits March 8, 2021 11:54
Seemingly when changing over to the Sema calls directly (instead of
going through the Evaluation contexts) I completely messed up the logic.
It wasn't even a difficult change, it should have been a simple 'replace
this call with that', but instead I mangled it beyond belief. I blame
Monday.
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bader bader merged commit d988bb3 into intel:sycl Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants