[SYCL] Add ITT annotations for SPIR functions as well #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if was done one for SPIR kernels Signed-off-by: Dmitry Sidorov <[email protected]>
|
bader
reviewed
Mar 19, 2021
Signed-off-by: Dmitry Sidorov <[email protected]>
Signed-off-by: Dmitry Sidorov <[email protected]>
bader
previously approved these changes
Mar 19, 2021
Signed-off-by: Dmitry Sidorov <[email protected]>
bader
approved these changes
Mar 19, 2021
|
@MrSidims, please, take a look at pre-commit failures. |
Taking a look |
|
@bader I have restarted precommit to see if its sporadic (or at least pressed the button). TBH I have no clue, how this patch could affect the failure: under gdb compilation of the test never passes through "SPIRITTAnnotationsPass::run" function. Also local execution of the test results in an assertion `(BT->getBitWidth() == 64 || (ConstValue >> BT->getBitWidth()) == 0) && "Size of externally provided specialization constant value doesn't" "fit into the specialization constant type"' with a compiler build of 20th of March. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if was done one for SPIR kernels
Signed-off-by: Dmitry Sidorov [email protected]