[SYCL][FPGA] Refactor of [[intel::force_pow2_depth()]] attribute #3387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2021 07:21
This patch 1. refactors FPGA Decl attribute [[intel::force_pow2_depth()]] to better fit for community standards. 2. refactors the way we handle duplicate attributes with same and different argument values and mutually exclusive attributes logic when present on a given declaration. 3. handles redeclarations or template instantiations properly. 4. adds tests 5. removes AddOneConstantValueAttr() function. 6. adds tests to chevk for global constant variable (which allows the redeclaration) since IntelFPGAConstVar is one of the subjects listed for [[intel::force_pow2_depth()]] attribute. 7. removes arbitrary upper bound check for attribute argument. Signed-off-by: soumi.manna <[email protected]>
Signed-off-by: soumi.manna <[email protected]>
Signed-off-by: soumi.manna <[email protected]>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
Signed-off-by: soumi.manna <[email protected]>
added 2 commits
March 25, 2021 08:36
Signed-off-by: soumi.manna <[email protected]>
Signed-off-by: soumi.manna <[email protected]>
premanandrao
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
refactors FPGA Decl attribute [[intel::force_pow2_depth()]]
to better fit for community standards.
refactors the way we handle duplicate attributes with same and
different argument values and mutually exclusive attributes logic
when present on a given declaration.
handles redeclarations or template instantiations properly.
adds tests
removes AddOneConstantValueAttr() function.
adds tests to check for global constant variable (which allows the redeclaration)
since IntelFPGAConstVar is one of the subjects listed for [[intel::force_pow2_depth()]] attribute.
removes arbitrary upper bound check for attribute argument.
Signed-off-by: soumi.manna [email protected]