[ESIMD] Get rid of __SYCL_EXPLICIT_SIMD__ macro #3404
Conversation
DenisBakhvalov
requested review from
elizabethandrews,
premanandrao and
a team
as code owners
| @@ -207,6 +206,7 @@ template <access::mode AccessMode> struct opencl_image1d_buffer_type; | |||
| __SYCL_IMAGE_BUFFER_TY_DEFINE(read, ro); | |||
| __SYCL_IMAGE_BUFFER_TY_DEFINE(write, wo); | |||
| __SYCL_IMAGE_BUFFER_TY_DEFINE(discard_write, wo); | |||
| __SYCL_IMAGE_BUFFER_TY_DEFINE(discard_read_write, rw); | |||
There was a problem hiding this comment.
Why this change is needed? The comment above says __SYCL_IMAGE_BUFFER_TY_DEFINE is not used anymore.
There was a problem hiding this comment.
This change was needed a there was a specialization of accessor class with discard_read_write. Since we "unguard" this code from -fsycl-explicit-simd I need to add that.
Anyway, with my recent changes, this code is gone.
| @@ -29,6 +29,7 @@ SYCL_EXTERNAL void hostAcc(accessor<int, 1, access::mode::read, access::target:: | |||
| // CHECK-NEXT: 16 | size_t [1] common_array | |||
| // CHECK-NEXT: 24 | union sycl::accessor<int, 1, sycl::access::mode::read, sycl::access::target::global_buffer, sycl::access::placeholder::false_t> | |||
| // CHECK-NEXT: 24 | sycl::accessor<int, 1, sycl::access::mode::read, sycl::access::target::global_buffer, sycl::access::placeholder::false_t>::ConcreteASPtrType MData | |||
| // CHECK-NEXT: 24 | sycl::accessor<int, 1, sycl::access::mode::read, sycl::access::target::global_buffer, sycl::access::placeholder::false_t>::OCLImage1dBufferTy ImageBuffer | |||
There was a problem hiding this comment.
Please clarify if the ImageBuffer field was present before the change. Otherwise this would be ABI-breaking.
There was a problem hiding this comment.
Ok. I reverted this change and instead of breaking the ABI of SYCL device code, my patch now breaks ABI of ESIMD device code. Hope it is OK for us to do.
|
@DenisBakhvalov the patch doesn't have all required approvals from code owners. |
|
@romanovvlad, can you please review on behalf of @intel/llvm-reviewers-runtime? |
No description provided.