[SYCL][FPGA] Add implicit memory attribute with [[intel::max_replicates()]] #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es()]] If the declaration does not have an [[intel::fpga_memory]] attribute, we create one as an implicit attribute. During refactoring work with [[intel::max_replicates()]] attribute, we somehow dropped the implicit memory attribute. This patch fixes the problem. Signed-off-by: soumi.manna <[email protected]>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
smanna12
changed the title
zahiraam
previously approved these changes
Mar 25, 2021
clang/lib/Sema/SemaDeclAttr.cpp
Outdated
| // attribute, this creates one as an implicit attribute. | ||
| if (!D->hasAttr<IntelFPGAMemoryAttr>()) | ||
| D->addAttr(IntelFPGAMemoryAttr::CreateImplicit( | ||
| Context, IntelFPGAMemoryAttr::Default)); |
There was a problem hiding this comment.
Does it make sense to do this outside the if condition? i.e. we want to do this regardless of E's value dependency, no?
There was a problem hiding this comment.
Good catch! Same goes for checking for mutual exclusion, I suppose.
There was a problem hiding this comment.
yes, I will fix this and upload new patch. Thanks
Signed-off-by: soumi.manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
premanandrao
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the declaration does not have an [[intel::fpga_memory]] attribute,
we create one as an implicit attribute.
During refactoring work with [[intel::max_replicates()]] attribute, we somehow
dropped the implicit memory attribute.
This patch fixes the problem.
Signed-off-by: soumi.manna [email protected]