[SYCL] Replace spec constants 2020 with RT-provided values in sycl-post-link #3430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-link By doing this change, SpecConstantsPass starts to replace scalar specialization constants with a user-provided value from RT (instead of using C++ default initialization value) for AOT mode. This is done with the new intrinsic __sycl_getScalar2020SpecConstantValue: the 3rd argument `RTBuffer` is a pointer to a runtime buffer, which holds values of all specialization constants.
| %3 = bitcast %struct._ZTS1A.A* %c.i to i8* | ||
| call void @llvm.lifetime.start.p0i8(i64 8, i8* nonnull %3) #3 | ||
| call spir_func void @_Z40__sycl_getComposite2020SpecConstantValueI13MyComposConstET_PKcPvS4_(%struct._ZTS1A.A addrspace(4)* sret(%struct._ZTS1A.A) align 4 %c.ascast.i, i8 addrspace(4)* getelementptr inbounds ([20 x i8], [20 x i8] addrspace(4)* addrspacecast ([20 x i8] addrspace(1)* @__builtin_unique_stable_name._ZNK2cl4sycl6ONEAPI12experimental13spec_constantI13MyComposConstE3getIS4_EENSt9enable_ifIXaasr3std8is_classIT_EE5valuesr3std6is_podIS9_EE5valueES9_E4typeEv to [20 x i8] addrspace(4)*), i64 0, i64 0), i8 addrspace(4)* null, i8 addrspace(4)* null) #4 | ||
| ; CHECK: %[[GEP:[0-9a-z]+]] = getelementptr i8, i8 addrspace(4)* null, i32 0 |
There was a problem hiding this comment.
This gep from nullptr looks a bit strange, but I guess this is because we pass null to the third argument of the intrinsic. Would be good to somehow change the test so we have a gep from an actual value
kbobrovs
reviewed
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this change, SpecConstantsPass starts to replace scalar specialization
constants with a user-provided value from RT (instead of using C++ default
initialization value) for AOT mode.
This is done with the new intrinsic __sycl_getScalar2020SpecConstantValue:
the 3rd argument
RTBufferis a pointer to a runtime buffer, which holdsvalues of all specialization constants.