[SYCL] Add infrastructure for integration footer #3455
Conversation
erichkeane
requested review from
AaronBallman,
AGindinson and
elizabethandrews
as code owners
We need a separate header that the driver will insert at the end of host translation unit to support SYCL 2020 spec-constants and is_device_copyable (plus potentially more in the future). This patch puts the infrastructure together so that these things can be added when final specifications are available, and so that the driver can implement their component.
erichkeane
force-pushed
the
post_int_header
branch
from
6263bab to
50732ff
Compare
|
force pushed instead of merge because I'm a bit of a jerk :) I figured no one had really looked at this, so it wouldn't be harmful to force-push on this. |
Since we have a handful of dependencies on this 'existing' (that is, the driver needs this patch to do their work in place), AND it doesn't really do anything yet, I'd like to get this in as a 'just infrastructure' patch. Otherwise we end up with a little bit of a standoff where the driver changes cant go in until this does, and vice versa. There are some OTHER standoffs (adding functionality to this patch at one point requires library stuff to go in first), but this unblocks those at least a little as well. |
|
Hold up on merging this, i noticed that the spec changed this to be a more-correctly named "Integration Footer". I'm going to do that rename and re-submit. |
erichkeane
changed the title
erichkeane
dismissed stale reviews from mdtoguchi, premanandrao, and AaronBallman
via
789d13c
|
Alright, I went through and renamed it to integration-footer to be more consistent with the spec. have at it all :) |
We need a separate header that the driver will insert at the end of host
translation unit to support SYCL 2020 spec-constants and
is_device_copyable (plus potentially more in the future). This patch
puts the infrastructure together so that these things can be added when
final specifications are available, and so that the driver can implement
their component.