Skip to content

[ESIMD] Deprecate -fsycl-explicit-simd option #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 8, 2021
Merged

[ESIMD] Deprecate -fsycl-explicit-simd option #3476

merged 8 commits into from
Apr 8, 2021

Conversation

DenisBakhvalov
Copy link
Contributor

@DenisBakhvalov DenisBakhvalov commented Apr 2, 2021 •
edited
Loading

ESIMD no longer requires -fsycl-explicit-simd flag.

@DenisBakhvalov
[ESIMD] Remove -fsycl-explicit-simd option
6245406 
ESIMD no longer requires -fsycl-explicit-simd flag, so it can be removed.
@DenisBakhvalov
Copy link
Contributor Author

Documentation will be updated in a separate patch. I'm working on it right now.

@DenisBakhvalov
Copy link
Contributor Author

Documentation will be updated in a separate patch. I'm working on it right now.

The patch is here: #3477

mdtoguchi
mdtoguchi reviewed Apr 2, 2021
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any users of the option? Does this need to go through a deprecation process before we remove?

@DenisBakhvalov
Copy link
Contributor Author

Are there any users of the option?
You mean any external users, right?

Does this need to go through a deprecation process before we remove?
ESIMD is still an experimental feature, however, I'm not sure about this. @kbobrovs, what do you think?

@AaronBallman
Copy link
Contributor

Are there any users of the option?
You mean any external users, right?

Does this need to go through a deprecation process before we remove?
ESIMD is still an experimental feature, however, I'm not sure about this. @kbobrovs, what do you think?

How long as the experimental feature been available for to users? Do we know of anyone using it?

@kbobrovs
Copy link
Contributor

kbobrovs commented Apr 2, 2021

Yes, this is experimental feature. But I suggest to leave it there, adding a deprecation message and saying that it has no effect now.

@pvchupin
Copy link
Contributor

pvchupin commented Apr 2, 2021

Yes, this is experimental feature. But I suggest to leave it there, adding a deprecation message and saying that it has no effect now.

I think it's OK to update all our tests reflecting new behavior. For the option itself we need a message that it's deprecated and not needed anymore.

@pvchupin
Copy link
Contributor

pvchupin commented Apr 2, 2021

Also please add it to the list at https://github.com/intel/llvm/blob/sycl/sycl/doc/UsersManual.md under [DEPRECATED] tag

@DenisBakhvalov
Copy link
Contributor Author

Yes, this is experimental feature. But I suggest to leave it there, adding a deprecation message and saying that it has no effect now.

I think it's OK to update all our tests reflecting new behavior. For the option itself we need a message that it's deprecated and not needed anymore.

Ok, will update the patch.

@DenisBakhvalov DenisBakhvalov requested a review from pvchupin as a code owner April 5, 2021 22:49
pvchupin
pvchupin previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for doc

mdtoguchi
mdtoguchi reviewed Apr 5, 2021
View reviewed changes
mdtoguchi
mdtoguchi reviewed Apr 6, 2021
View reviewed changes
kbobrovs
kbobrovs reviewed Apr 6, 2021
View reviewed changes
alexbatashev
alexbatashev previously approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM

mdtoguchi
mdtoguchi previously approved these changes Apr 6, 2021
View reviewed changes
mdtoguchi
mdtoguchi reviewed Apr 6, 2021
View reviewed changes
alexbatashev
alexbatashev previously approved these changes Apr 6, 2021
View reviewed changes
kbobrovs
kbobrovs previously approved these changes Apr 6, 2021
View reviewed changes
@DenisBakhvalov
Copy link
Contributor Author

@AaronBallman, @premanandrao, @AGindinson, @elizabethandrews, please review.

AaronBallman
AaronBallman previously approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a tiny commenting nit.

@DenisBakhvalov
Copy link
Contributor Author

@bader, I believe some of the reviewers are on vacation. Can we consider this patch as approved?

@DenisBakhvalov DenisBakhvalov changed the title [ESIMD] Remove -fsycl-explicit-simd option [ESIMD] Deprecate -fsycl-explicit-simd option Apr 8, 2021
@pvchupin pvchupin requested a review from mdtoguchi April 8, 2021 06:50
@bader
Copy link
Contributor

bader commented Apr 8, 2021

@bader, I believe some of the reviewers are on vacation. Can we consider this patch as approved?

You need an approval from driver code owners. Even if they are on vacation (which according to my information is not the case), I don't understand why this patch can be considered as approved. I see that Mike left multiple comments, so I would like to get his approval before merging the patch.

mdtoguchi
mdtoguchi previously approved these changes Apr 8, 2021
View reviewed changes
@bader bader dismissed stale reviews from mdtoguchi, AaronBallman, kbobrovs, and alexbatashev via f709b6c April 8, 2021 14:44
@bader bader merged commit 6e9ddb6 into intel:sycl Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev left review comments

@AaronBallman AaronBallman AaronBallman left review comments

@kbobrovs kbobrovs kbobrovs left review comments

@pvchupin pvchupin pvchupin left review comments

@mdtoguchi mdtoguchi mdtoguchi left review comments

@AGindinson AGindinson Awaiting requested review from AGindinson

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@premanandrao premanandrao Awaiting requested review from premanandrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DenisBakhvalov @AaronBallman @kbobrovs @pvchupin @bader @alexbatashev @mdtoguchi